hope this works #3

galjs · 2020-03-19T20:58:25Z

comments:

clean_code/clean_code.pyproj

yairzori

Good job! :). I left a lot of comments, you can disagree with some of them, just tell me. In any case, talk with me before you are starting to fix your code.

clean_code/game.py

clean_code.sln

clean_code/game.py

clean_code/bfs_maze.py

clean_code/graph.py

clean_code/maze.py

clean_code/missing_number.py

clean_code/test_missing_number.py

clean_code/bfs_search.py

clean_code/maze.py

clean_code/graph.py

clean_code/maze.py

clean_code/pattern_algorithms.py

clean_code/test_pattern_algorithms.py

clean_code/pattern_algorithms.py

clean_code/algorithms/creation_algorithms.py

clean_code/test_pattern_algorithms.py

clean_code/algorithms/pattern_algorithms.py

clean_code/algorithms/creation_algorithms.py

clean_code/test_pattern_algorithms.py

clean_code/algorithms/creation_algorithms.py

clean_code/algorithms/pattern_algorithms.py

clean_code/algorithms/creation_algorithms.py

clean_code/algorithms/pattern_algorithms.py

yairzori · 2020-03-26T18:23:12Z

clean_code/algorithms/pattern_algorithms.py

+            #if current_length > longest_length:
+            #    longest_length = current_length
+            #    start_index = index


Remove commented code

galjs added 22 commits March 18, 2020 15:21

Add project files.

40b5179

added cell and maze classes

25315ae

created cell class and maze class

16f8d1b

fixed a bug with the proportions of the board

f01f2b7

added board verification

ed26f6d

changed printing functions to __str__ format

6bd7ef9

added junction calss

faaa9c5

added Connection class

763d554

add Position class

7716b6b

adding to_graph methods to Maze

eaeb37e

changed junction

d06c8cc

sorting things out

4f2e383

graph ready

3539bb1

graph is complete. cell has mark attribute

933a65f

new bfs_maze and discovered attribute for junction

00618e6

all is complete except the algorithm

d8f3949

bfs_maze is ready

56b33c2

algorithem finds the finish

0b333d2

maze solved

71370c8

raise an error if no solution available

4b7cd96

new missing_number file

7f87257

try #2

86d2aa1

yairzori reviewed Mar 19, 2020

View reviewed changes

clean_code/clean_code.pyproj Outdated Show resolved Hide resolved

yairzori suggested changes Mar 20, 2020

View reviewed changes

galjs added 6 commits March 22, 2020 12:48

working up to "this function should be in Graph"

8ef491a

workung up to "This also can be a function of Graph"

d588f5f

test_maze, cell, bfs_graph now working

548f237

graph also working now

5afa6be

junction working

b24fee5

maze is working

ac50ec9

galjs added 6 commits March 23, 2020 11:05

no more changes

c153e56

working state

25f113c

halfway through...

bf75af5

bfs_maze complete

804f53b

complete

c66e111

deleted trailing lines

6f280b7

yairzori suggested changes Mar 23, 2020

View reviewed changes

galjs added 3 commits March 23, 2020 17:37

bfs_search corrected

61a52b4

everything except _update_junctions

c7ad1eb

more algorithms

f8e32a7

yairzori suggested changes Mar 24, 2020

View reviewed changes

clean_code/bfs_search.py Outdated Show resolved Hide resolved

clean_code/bfs_search.py Show resolved Hide resolved

clean_code/bfs_search.py Show resolved Hide resolved

clean_code/maze.py Outdated Show resolved Hide resolved

clean_code/graph.py Outdated Show resolved Hide resolved

galjs added 4 commits March 24, 2020 10:28

all changes made

cca3508

iterator permutations

80d7f71

variable names changes

b02bccd

recursive permutations

b107665

yairzori suggested changes Mar 24, 2020

View reviewed changes

clean_code/graph.py Outdated Show resolved Hide resolved

clean_code/maze.py Show resolved Hide resolved

yairzori suggested changes Mar 24, 2020

View reviewed changes

clean_code/pattern_algorithms.py Outdated Show resolved Hide resolved

clean_code/pattern_algorithms.py Outdated Show resolved Hide resolved

galjs added 3 commits March 24, 2020 21:22

all changes complete

93f5db1

all algorithms complete

ba682d4

more readable and with new test class

2863363

yairzori suggested changes Mar 25, 2020

View reviewed changes

completed all changes + algorithms are now in a package

d622bf9

yairzori suggested changes Mar 25, 2020

View reviewed changes

all cahnges made

d88d695

yairzori suggested changes Mar 26, 2020

View reviewed changes

fixed

51364e0

yairzori suggested changes Mar 26, 2020

View reviewed changes

clean_code/algorithms/creation_algorithms.py Show resolved Hide resolved

clean_code/algorithms/pattern_algorithms.py Outdated Show resolved Hide resolved

clean_code/algorithms/pattern_algorithms.py Outdated Show resolved Hide resolved

fixed again

34435ca

yairzori suggested changes Mar 26, 2020

View reviewed changes

fixed the mistake

f4e4563

hope this works #3

Are you sure you want to change the base?

hope this works #3

Uh oh!

Conversation

galjs commented Mar 19, 2020

Uh oh!

Uh oh!

yairzori left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yairzori Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!